Cancel .task work when the view disappears - #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.tasknow cooperatively cancels its async closure when the view leaves the tree, matching SwiftUI. Previously it launched aTaskon appear that ran forever.Mechanism
.taskmodifier registers two callbacks —startandcancel— and the launchedTaskis stored in a registry keyed by the view's stable identity path, not by the callback id.starton appear (DisposableEffectenter) andcancelononDispose.Why key by identity path
Callback ids are generation-scoped and evicted after one cycle, but a view can re-evaluate many times between appear and disappear — so a captured cancel id would be long gone by dispose. Keying the running
Taskby identity path (stable across every re-evaluation) makes cancel find the right task regardless. The interpreter also handsonDisposethe freshest cancel id via a remembered holder, so the callback itself stays resolvable.The user's closure observes cancellation the normal way (
Task.sleep/Task.isCancelledthrow/return on cancel).Verification
swift test— new start/cancel test (launches then cancels via the two ids, asserts the registry clears), 67 total passing